Query on custom implementation of pipecmds in clispec

YANG
1

Hi,

I am trying to implement custom tab completion mechanism for save option in pipecmds.
I have in the below ways

#1)
Delete the default save using “delete”
Add custom command and tab completion.

In this case I am able to use custom tab completion but I am unable to redirect/get the output of command before pipe.

for example file tail -n 10 abc.log | save log/test.log
I am unable to redirect output of “file tail -n 10 abc.log” to script handling the “save”

#2)
Modify the existing tab completion of save using “modification”

<modifications>
      <completion path="save">
      <callback>
                <capi>
                    <completionpoint>tab-completion-save</completionpoint>
                </capi>
            </callback>
     </completion>
</modifications>

In this case the custom tab completion itself is not working.

Could you help to correct my mistakes or add something I am missing

2

Your approach to replacing the built-in save pipe command should work; perhaps paths in your clispec file are not correct?

But custom completions probably cannot work like that; I believe completions like this (i.e. using the <completion/> element) can be used only for completing in the context of auto-rendered commands. You can use completion points attached to types though - i.e. you define a YANG-modeled type, use it in your clispec file and attach a completion point to it. Have a look at the cli/completions example.

3

Thanks for the response.
By following “replacing the built-in save pipe command”, how to redirect the output to custom script.
For example

file show test.log | save log/test1.log

how to redirect the output of file show to custom script that handles ‘save’ command.

<pipeCmds>
<cmd name="save">
    <info>Save the content of file</info>
    <help>Save the content of file</help>
    <params>
        <param>
            <callback>
                <capi>
                    <completionpoint>tab-completion-save</completionpoint>
                </capi>
            </callback>
        </param>
    </params>
    <callback>
        <exec>
            <osCommand>/usr/bin/file.sh</osCommand>
            <args>file_save</args>
        </exec>
    </callback>
</cmd>
</pipeCmds>

file.sh script is being invoked but it does not receive the output of ‘file show’ command

4

The clispec snippet looks fine, except that you do not delete or hide the built-in “save” pipe command, that might cause what you describe.

5

I have added the delete of existing save command, forgot to add it in the comment/question.
but the back end script does not receive any input from the previous command.

I have also tried with a different name like xsave but still face the same issue


<operationalMode>
        <modifications>
            <addPipeFlags src="file">xsave</addPipeFlags>
        </modifications>
<operationalMode>

<pipeCmds>
<cmd name="xsave">
    <info>Output the content of file</info>
    <help>Output the content of file</help>
    <options>
        <pipeFlags>xsave</pipeFlags>
    </options>
    <params>
        <param>
            <callback>
                <capi>
                    <completionpoint>tab-completion-save</completionpoint>
                </capi>
            </callback>
            <type><file wd="virt/"/></type>
        </param>
    </params>
    <callback>
        <exec>
            <osCommand>/usr/bin/file_utils.sh</osCommand>
            <args>file_save</args>
            <options>
                <interrupt>sigterm</interrupt>
                <ignoreExitValue/>
            </options>
        </exec>
    </callback>
</cmd>
</pipeCmds>
6

That part options/pipeFlags should not be there. I don’t think it makes sense to add a pipeFlag to “itself”.

What I did is that I took your clispec snippet, added it to the introductory ConfD example’s commands-c.cli, did few modifications for my environment, removed that pipeFlags option, and it works. If it does not work in your environment, something must be wrong with that.

7

If I remove the options/pipeFlag, I see the new command ‘xsave’ in pipe options.
Also the tab completion works. But the backend callBack/exec/osCommand (file_utils.sh) hooked to ‘xsave’ does not receive the output of ‘file show’ ( complete command: file show test.log | save log/test1.log)

I am expecting to redirect the out of ‘file show’ to ‘xsave’ so that I could process it using the callBack/exec/osCommand (file_utils.sh), the osCommand is invoked with out any input(I have printed the command line arguments (’$@’) in shell script and they were empty).

How can I pass the output of file show to the new pipeCmd ‘xsave’.

8

You write that $@ is empty - that’s weird, it should contain exactly two arguments:

  1. the file_save string that you declare as an argument
  2. the file parameter.

If it does not, it means something else is not working as it should. But in either case, the input data is not provided through arguments, you should read it from stdin, so in your shell script using read or something like that.

9

sorry for the confusion.
When I said $@ was empty, I meant it does not have any data from previous command ‘file show’.

We tried in the following ways

Initially tried to read the input using “read”(read $input), as we do in shell script to read input from redirection. When I tried to print the data read from ‘read’ it was empty.

We also tried like below
if [ -p /dev/stdin ]; then
echo “Data was piped to this script!”
# If we want to read the input line by line
while IFS= read line; do
echo “Line: ${line}”
done
fi
to check if the data piped to script.

In the both the above cases, we only see “file_save log/test1.log” in both command line arguments and in data read from ‘read’ call.

10

Are you sure /dev/stdin needs to be (a link to) a pipe? In my environment it is a link to a socket; not sure how this can be, but simply -p test may not work.

11

if I remove the if block (/dev/stdin), I am able to read the data from redirection.
Thanks a lot for the quick reply and support